Jimmy (![[info]](http://p-stat.livejournal.com/img/userinfo.gif){kind=small} scenejournal) wrote in ![[info]](http://p-stat.livejournal.com/img/community.gif){kind=small} lj_dev,@ 2008-04-17 21:43:00 |
|
/support/help.bml Code
Hey,
I have users who want to help out other users in the support queue, but whenever they try to visit the page (by clicking on the link to go to the queue from the /support/index.bml page they're told the support queue is only available to people with the privs. So I had a peek at the code in the /support/help.bml page and there was this chunk of code:
return $ML{'.interim'} if
(!$remote || !$remote->{'_priv'}) &&
($r->header_in("Referer") eq "$LJ::SITEROOT/support/" || $r->header_in("Referer") eq "$LJ::SITEROOT/support/index.bml" || $r->header_in("Referer") eq "$LJ::SITEROOT/support/submit.bml");
It makes sense to me about what it's doing, but not why it's there...anyone know why you would block people from clicking that link? I tried it on LiveJournal and it works as intended, it shows you the queue and allows users to submit screened responses which is what I am going for...
In my database I have categories with public_help turned off (0) and allow_screened turned on (1).
So now I appear to be getting the sam effect as on LiveJournal, normal users can submit a screened response and I as the admin can change categories, rename topics, etc...and when someone who is not logged in viewed a thread it says they need to login to help others out, although they can still see all the information about the user (styles, email validated, etc...) so maybe the better idea here would be to insert some code that made sure the user was logged in and if so, then they can see all the support threads, maybe a better idea to toss that error out instead of saying users need special privs...
But then maybe I am mistaken and am looking at this the wrong way!
Any help on why that chunk of code is there would be great... :)
Hey,
I have users who want to help out other users in the support queue, but whenever they try to visit the page (by clicking on the link to go to the queue from the /support/index.bml page they're told the support queue is only available to people with the privs. So I had a peek at the code in the /support/help.bml page and there was this chunk of code:
return $ML{'.interim'} if
(!$remote || !$remote->{'_priv'}) &&
($r->header_in("Referer") eq "$LJ::SITEROOT/support/" || $r->header_in("Referer") eq "$LJ::SITEROOT/support/index.bml" || $r->header_in("Referer") eq "$LJ::SITEROOT/support/submit.bml");
It makes sense to me about what it's doing, but not why it's there...anyone know why you would block people from clicking that link? I tried it on LiveJournal and it works as intended, it shows you the queue and allows users to submit screened responses which is what I am going for...
In my database I have categories with public_help turned off (0) and allow_screened turned on (1).
So now I appear to be getting the sam effect as on LiveJournal, normal users can submit a screened response and I as the admin can change categories, rename topics, etc...and when someone who is not logged in viewed a thread it says they need to login to help others out, although they can still see all the information about the user (styles, email validated, etc...) so maybe the better idea here would be to insert some code that made sure the user was logged in and if so, then they can see all the support threads, maybe a better idea to toss that error out instead of saying users need special privs...
But then maybe I am mistaken and am looking at this the wrong way!
Any help on why that chunk of code is there would be great... :)
