12:57 pm, 3 Aug 08
git and rietveld (codereview.appspot.com)
Lately in my spare time I've been working on adding Git support to Rietveld. (Rietveld is the code review tool that Guido wrote as an App Engine demo. It's similar to Mondrian but open-source and not as tied into Google's workflows. Unfortunately, up until recently it was pretty Subversion-specific, making assumptions like expecting URLs to HTTP-accessible svn repositories. For what it's worth, a likely better system is Review Board; I just think code review is great in general.)
My Rietveld refactoring patch is now in, and we continue to discuss the Git-specific followup. (Thankfully, someone working on Mercurial support already did a lot of the hard initial work.) I've also written a more git-oriented subcommand which works like this: you run
My Rietveld refactoring patch is now in, and we continue to discuss the Git-specific followup. (Thankfully, someone working on Mercurial support already did a lot of the hard initial work.) I've also written a more git-oriented subcommand which works like this: you run
git cl upload to put a branch up for review, and git cl dcommit flushes the current branch into a single svn commit using the description from the Rietveld review.
I did a presentation a couple of weeks ago where I convinced my team to experiment with code reviews once the tool was ready, but unfortunately that's probably up in the air since I'm leaving soon.
Code Reviews overall
The past few months I have been pondering code reviews a fair amount and the different ways that they are implemented. You blog finally kicked me into writing it all down. Hopefully it can provide some extra information for writing your toolhttp://benjamin-meyer.blogspot.com/2008/0
Review Board
My company is kind of using Review Board, it's pretty nice, but there are definitely some rough edges (way too many clicks to get anything done). It also has some weirdnesses with parent diffs that can make it hard to review changes from my git workflow (it's on an svn repo, and I'm working on that repo with git).-Jeff Hanke
I think djabberd is using Rietveld. I want to see If i can get that running in an in office environment (our svn is not public)
How would running a private app engine help? Wouldn't it still be hosted at google? It wouldn't have access to any repositories.
thanks for the information.
I'll probably look at reviewboard more.