mmadia ([info]mmadia) wrote in [info]bezilla,
@ 2008-03-24 00:46:00
Previous Entry  Add to memories!  Tell a Friend!  Next Entry
XULRunner attempt
After some small Makefile.in changes, XULRunner still fails in the same way as it did previously


/src/mozilla/xulrunner/stub/nsXULStub.cpp: In function `int main(int, char **)':
/src/mozilla/xulrunner/stub/nsXULStub.cpp:88: `realpath' undeclared (first use this function)
/src/mozilla/xulrunner/stub/nsXULStub.cpp:88: (Each undeclared identifier is reported only once
/src/mozilla/xulrunner/stub/nsXULStub.cpp:88: for each function it appears in.)
make[1]: *** [nsXULStub.o] Error 1
make[1]: Leaving directory `/obj/MozillaXULRunner-bone/xulrunner/stub'

tqh said this: -- links updated to "mozilla1.8/"
We don't use realpath to traverse sym-links:
http://lxr.mozilla.org/mozilla1.8/source/xulrunner/stub/nsXULStub.cpp#63

We should have a #ifdef XP_BEOS with something like:
http://lxr.mozilla.org/mozilla1.8/source/xpcom/obsolete/nsFileSpecBeOS.cpp#187 and on.

setenv, missing header?

Also note that BeOS execv is broken, and I hope this code at least doesn't relaunch itself, as Firefox does. If it does, it's a nasty hack that is just plain ugly. "
Anyway i can interest someone into
:END QUOTE

can i interest anyone in helping with that bit?

Update: with code from bekeeper's nsXULStub.cpp, xulrunner built successfully.
However, i still need to learn how to test the actual application. Afterwards, i'll make and submit a patch.

After that, i'll recheck my re-ordering patches with a shared+debug builds. If that goes well, i'll submit those patches.



(Post a new comment)


[info]fyysik
2008-03-24 09:11 am UTC (link)
not that execv is really broken, I had version with execv which worked, but we use for relaunching bit more "native" way - see FF launcher.

about realpath - IIRC when we worked on trunk, I submitted solution which uses native syscalls as in that example instead realpath. So, no problems to solve those issues, just need day or two of free time.

Please, remind me before weekend.

(Reply to this) (Thread)


[info]tqh
2008-03-24 09:31 am UTC (link)
Yes, fyysik solved the execv problem for Firefox. So that shouldn't be a problem. Btw I guess those comments are a bit old by now (1-2 years?)

(Reply to this) (Parent)(Thread)


[info]mmadia
2008-03-24 10:02 am UTC (link)
almost a full two years... apr 17 2006
http://community.livejournal.com/bezilla/186779.html

here's another related one a week or so later:
http://community.livejournal.com/bezilla/187619.html

also, standalone composer is dead in the water.
it's horribly broken on all OS's and not even present in trunk anymore.

(Reply to this) (Parent)


[info]bekeeper
2008-03-24 03:02 pm UTC (link)
mmadia,

I actually was able to compile XULRunner successfully though I never tried to run it because I only wanted the Plugin SDK (which I still have not been able to use because of other problems). But I can send you the files I modified (thanks to fyysik) and maybe that can help you.

(Reply to this) (Thread)


[info]mmadia
2008-03-24 09:58 pm UTC (link)
that would be excellent, my "@gmail.com" account is "mattmadia"

(Reply to this) (Parent)


Create an Account
Forgot your login or password?
Login w/ OpenID
English • Español • Deutsch • Русский…